usb: gadget: dummy_hcd: fix null-deref free req

_ep to ep is a pointer substraction so ep won't be zero unless _ep was
8. This was not intendent by the author, it was probably a typo while
checking for NULL of the argument.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 9170a4c7ced412724db3645eb58cf3e5f61aa3a7..8cc1a88d21e7be0ac0941c8b5d383a81eaae5b96 100644 (file)
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -599,8 +599,10 @@ static void dummy_free_request(struct usb_ep *_ep, struct usb_request *_req)
        struct dummy_ep         *ep;
        struct dummy_request    *req;
 
+       if (!_ep || !_req)
+               return;
        ep = usb_ep_to_dummy_ep(_ep);
-       if (!ep || !_req || (!ep->desc && _ep->name != ep0name))
+       if (!ep->desc && _ep->name != ep0name)
                return;
 
        req = usb_request_to_dummy_request(_req);