staging: comedi: adl_pci9111: cleanup pci9111_ao_insn_write()
authorH Hartley Sweeten <hartleys@visionengravers.com>
Tue, 11 Sep 2012 01:54:08 +0000 (18:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Sep 2012 03:02:24 +0000 (20:02 -0700)
Remove the unnecessary comment.

Only the last data value written needs to be cached for
readback.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adl_pci9111.c

index d5226a8c573af6df91b66cf4f0f892128dc24a03..10f1b87affec3d60f8dfc5ac9835014a32206dd2 100644 (file)
@@ -1035,22 +1035,22 @@ conversion_done:
        return i;
 }
 
-/*  Analog instant output */
-
-static int
-pci9111_ao_insn_write(struct comedi_device *dev,
-                     struct comedi_subdevice *s, struct comedi_insn *insn,
-                     unsigned int *data)
+static int pci9111_ao_insn_write(struct comedi_device *dev,
+                                struct comedi_subdevice *s,
+                                struct comedi_insn *insn,
+                                unsigned int *data)
 {
        struct pci9111_private_data *dev_private = dev->private;
+       unsigned int val = 0;
        int i;
 
        for (i = 0; i < insn->n; i++) {
-               outw(data[i], dev->iobase + PCI9111_AO_REG);
-               dev_private->ao_readback = data[i];
+               val = data[i];
+               outw(val, dev->iobase + PCI9111_AO_REG);
        }
+       dev_private->ao_readback = val;
 
-       return i;
+       return insn->n;
 }
 
 static int pci9111_ao_insn_read(struct comedi_device *dev,