staging: vc04_services: Make vchi_msg_queue static
authorMichael Zoran <mzoran@crowfest.net>
Mon, 30 Jan 2017 07:31:11 +0000 (23:31 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Jan 2017 09:48:14 +0000 (10:48 +0100)
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.

Make the function static and remove it from the exported
symbols.

Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchi/vchi.h
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c

index 1a401f04d03f7b09c377c58191eafaac51ff6e8a..addb7b00b688be337c68fca1823d77da9c5786b3 100644 (file)
@@ -219,14 +219,6 @@ extern int32_t vchi_service_set_option( const VCHI_SERVICE_HANDLE_T handle,
                                        VCHI_SERVICE_OPTION_T option,
                                        int value);
 
-// Routine to send a message across a service
-extern int32_t
-       vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle,
-                      ssize_t (*copy_callback)(void *context, void *dest,
-                                               size_t offset, size_t maxsize),
-                      void *context,
-                      uint32_t data_size);
-
 /* Routine to send a message from kernel memory across a service */
 extern int
 vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle,
index 8987c4ad3653412a99bc6fd2357ada1db020f735..aec2a0c40c440b48c2d4e74f4a4439e276bd0eaf 100644 (file)
@@ -158,6 +158,7 @@ EXPORT_SYMBOL(vchi_msg_remove);
  * Returns: int32_t - success == 0
  *
  ***********************************************************/
+static
 int32_t vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle,
        ssize_t (*copy_callback)(void *context, void *dest,
                                 size_t offset, size_t maxsize),
@@ -186,7 +187,6 @@ int32_t vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle,
 
        return vchiq_status_to_vchi(status);
 }
-EXPORT_SYMBOL(vchi_msg_queue);
 
 static ssize_t
 vchi_queue_kernel_message_callback(void *context,