uprobes: Change filter_chain() to iterate ->consumers list
authorOleg Nesterov <oleg@redhat.com>
Sat, 24 Nov 2012 17:15:46 +0000 (18:15 +0100)
committerOleg Nesterov <oleg@redhat.com>
Fri, 8 Feb 2013 16:47:05 +0000 (17:47 +0100)
Now that it safe to use ->consumer_rwsem under ->mmap_sem we can
almost finish the implementation of filter_chain(). It still lacks
the actual uc->filter(...) call but othewrwise it is ready, just
it pretends that ->filter() always returns true.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c

index 61d0fa6b5012a683976155834356dfcc8edfbb11..4d04523636869d269bb2119d0770aec4e4d0b987 100644 (file)
@@ -614,14 +614,19 @@ static int prepare_uprobe(struct uprobe *uprobe, struct file *file,
 
 static bool filter_chain(struct uprobe *uprobe)
 {
-       /*
-        * TODO:
-        *      for_each_consumer(uc)
-        *              if (uc->filter(...))
-        *                      return true;
-        *      return false;
-        */
-       return uprobe->consumers != NULL;
+       struct uprobe_consumer *uc;
+       bool ret = false;
+
+       down_read(&uprobe->consumer_rwsem);
+       for (uc = uprobe->consumers; uc; uc = uc->next) {
+               /* TODO: ret = uc->filter(...) */
+               ret = true;
+               if (ret)
+                       break;
+       }
+       up_read(&uprobe->consumer_rwsem);
+
+       return ret;
 }
 
 static int