[media] dibusb: fix possible memory leak in dibusb_rc_query()
authorWei Yongjun <weiyongjun1@huawei.com>
Sun, 30 Oct 2016 01:36:24 +0000 (23:36 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 21 Nov 2016 13:40:45 +0000 (11:40 -0200)
'buf' is malloced in dibusb_rc_query() and should be freed before
leaving from the error handling cases, otherwise it will cause
memory leak.

Fixes: ff1c123545d7 ("[media] dibusb: handle error code on RC query")

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb/dibusb-common.c

index de3ee2547479428cd1c14347db5332ea1090c60d..8207e6900656bef61de4f0df10b37b5cc6110f98 100644 (file)
@@ -382,9 +382,9 @@ int dibusb_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
        if (buf[0] != 0)
                deb_info("key: %*ph\n", 5, buf);
 
+ret:
        kfree(buf);
 
-ret:
        return ret;
 }
 EXPORT_SYMBOL(dibusb_rc_query);