netfilter: Move mutex_is_held under PROVE_LOCKING
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 13 Nov 2014 10:11:19 +0000 (18:11 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Nov 2014 20:13:05 +0000 (15:13 -0500)
The rhashtable function mutex_is_held is only used when PROVE_LOCKING
is enabled.  This patch modifies netfilter so that we can rhashtable.h
itself can later make mutex_is_held optional depending on PROVE_LOCKING.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nft_hash.c

index 8892b7b6184aaf9beafac3da8a665f5f4b696247..b86305c86048b4c97118b92abedaa97b8f5096b6 100644 (file)
@@ -153,10 +153,12 @@ static unsigned int nft_hash_privsize(const struct nlattr * const nla[])
        return sizeof(struct rhashtable);
 }
 
+#ifdef CONFIG_PROVE_LOCKING
 static int lockdep_nfnl_lock_is_held(void)
 {
        return lockdep_nfnl_is_held(NFNL_SUBSYS_NFTABLES);
 }
+#endif
 
 static int nft_hash_init(const struct nft_set *set,
                         const struct nft_set_desc *desc,
@@ -171,7 +173,9 @@ static int nft_hash_init(const struct nft_set *set,
                .hashfn = jhash,
                .grow_decision = rht_grow_above_75,
                .shrink_decision = rht_shrink_below_30,
+#ifdef CONFIG_PROVE_LOCKING
                .mutex_is_held = lockdep_nfnl_lock_is_held,
+#endif
        };
 
        return rhashtable_init(priv, &params);