[SCSI] libsas: Remove redundant phy state notification calls.
authorJeff Skirvin <jeffrey.d.skirvin@intel.com>
Fri, 16 Dec 2011 08:21:21 +0000 (08:21 +0000)
committerJames Bottomley <JBottomley@Parallels.com>
Sun, 19 Feb 2012 20:20:09 +0000 (14:20 -0600)
In the case of an explicit sas_phy_enable call to disable a phy,
the LLDD provides the calls to sas_phy_disconnected and the
PHYE_LOSS_OF_SIGNAL event.

NOTE: This assumes that the lldd(s) generate the notification, which
appears to be the case, but only verfied on isci.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/libsas/sas_init.c

index 53ae893e8b0b0860199a89550a8dae8891e70683..cf1b532b0e7653ce9f3fec0779b6f0b4e7f6f650 100644 (file)
@@ -268,11 +268,8 @@ static int sas_phy_enable(struct sas_phy *phy, int enable)
 
                if (enable)
                        ret = transport_sas_phy_reset(phy, 0);
-               else {
-                       sas_phy_disconnected(asd_phy);
-                       sas_ha->notify_phy_event(asd_phy, PHYE_LOSS_OF_SIGNAL);
+               else
                        ret = i->dft->lldd_control_phy(asd_phy, cmd, NULL);
-               }
        } else {
                struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent);
                struct domain_device *ddev = sas_find_dev_by_rphy(rphy);