iwlwifi: mvm: don't fail completely if led mode is not supported

Blink led mode is not supported by iwlmvm. This doesn't mean
that we should prevent any operation if it is selected by
the user.
Instead of failing without any notice to the user, fallback
to the default mode (RF mode) if the blink mode
is selected and print an error to inform the user.

Reported-by: Steven Haigh <netwiz@crc.id.au>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

diff --git a/drivers/net/wireless/iwlwifi/mvm/led.c b/drivers/net/wireless/iwlwifi/mvm/led.c
index 6b4ea6bf8ffeaf13273b1f79ec46057290254e31..e3b3cf4dbd77a461916589f3dc59f4f11aead0c5 100644 (file)
--- a/drivers/net/wireless/iwlwifi/mvm/led.c
+++ b/drivers/net/wireless/iwlwifi/mvm/led.c
@@ -94,6 +94,8 @@ int iwl_mvm_leds_init(struct iwl_mvm *mvm)
        int ret;
 
        switch (mode) {
+       case IWL_LED_BLINK:
+               IWL_ERR(mvm, "Blink led mode not supported, used default\n");
        case IWL_LED_DEFAULT:
        case IWL_LED_RF_STATE:
                mode = IWL_LED_RF_STATE;