ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Oct 2015 19:48:24 +0000 (15:48 -0400)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 21 Oct 2015 23:52:57 +0000 (16:52 -0700)
When CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, the
following link failures are caused:

drivers/built-in.o: In function `cygnus_armpll_init':
:(.init.text+0x1d290): undefined reference to `iproc_armpll_setup'
drivers/built-in.o: In function `cygnus_genpll_clk_init':
:(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup'
drivers/built-in.o: In function `cygnus_lcpll0_clk_init':
:(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup'
drivers/built-in.o: In function `cygnus_mipipll_clk_init':
:(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup'
drivers/built-in.o: In function `cygnus_asiu_init':
:(.init.text+0x1d370): undefined reference to `iproc_asiu_setup'

It is fixed it by always selecting COMMON_CLK_IPROC from
ARCH_BCM_IPROC, and making COMMON_CLK_IPROC a silent option (thus
preventing it from being erroneously disabled by a user).

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jon Mason <jonmason@broadcom.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
arch/arm/mach-bcm/Kconfig
drivers/clk/bcm/Kconfig

index 1319c3c14327864366e396ed93516732ff6453a5..84bd26535ae9d247a5f4c89eb6c95cfbaa643f6b 100644 (file)
@@ -14,7 +14,7 @@ config ARCH_BCM_IPROC
        select HAVE_ARM_SCU if SMP
        select HAVE_ARM_TWD if SMP
        select ARM_GLOBAL_TIMER
-
+       select COMMON_CLK_IPROC
        select CLKSRC_MMIO
        select ARCH_REQUIRE_GPIOLIB
        select ARM_AMBA
index 88febf53b276a9253bfaf4045799197901180687..46ee475a1d76b2d4c6928b9d06bb01ffd16ace71 100644 (file)
@@ -9,10 +9,8 @@ config CLK_BCM_KONA
          in the BCM281xx and BCM21664 families.
 
 config COMMON_CLK_IPROC
-       bool "Broadcom iProc clock support"
-       depends on ARCH_BCM_IPROC
+       bool
        depends on COMMON_CLK
-       default ARCH_BCM_IPROC
        help
          Enable common clock framework support for Broadcom SoCs
          based on the iProc architecture