net: change init_inodecache() return void
authoryuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Sat, 7 Jan 2017 09:18:31 +0000 (17:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Jan 2017 17:05:29 +0000 (12:05 -0500)
sock_init() call it but not check it's return value,
so change it to void return and add an internal BUG_ON() check.

Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/socket.c

index c65bb927b104dc6d8f9dc1d747a0fc43a5af4838..3ef02e97ecf32ed9ba28ab715347e1b6fa95c9b5 100644 (file)
@@ -287,7 +287,7 @@ static void init_once(void *foo)
        inode_init_once(&ei->vfs_inode);
 }
 
-static int init_inodecache(void)
+static void init_inodecache(void)
 {
        sock_inode_cachep = kmem_cache_create("sock_inode_cache",
                                              sizeof(struct socket_alloc),
@@ -296,9 +296,7 @@ static int init_inodecache(void)
                                               SLAB_RECLAIM_ACCOUNT |
                                               SLAB_MEM_SPREAD | SLAB_ACCOUNT),
                                              init_once);
-       if (sock_inode_cachep == NULL)
-               return -ENOMEM;
-       return 0;
+       BUG_ON(sock_inode_cachep == NULL);
 }
 
 static const struct super_operations sockfs_ops = {