staging: fsl-dpaa2/eth: Map Tx buffers as bidirectional
authorIoana Radulescu <ruxandra.radulescu@nxp.com>
Wed, 24 May 2017 12:13:28 +0000 (07:13 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 May 2017 14:57:20 +0000 (16:57 +0200)
WRIOP hardware may need to write to the hardware annotation
area of Tx buffers (e.g. frame status bits) and also to
the data area (e.g. L4 checksum in frame header).

Map these buffers as DMA_BIDIRECTIONAL, otherwise the
write transaction through SMMU will not be allowed.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

index 3fee0d6f17e0d192359b4ce2fb96ffcfd1e5e4ea..49c435bad70601cf9dcef99849ff6055255189e5 100644 (file)
@@ -355,7 +355,7 @@ static int build_sg_fd(struct dpaa2_eth_priv *priv,
 
        sg_init_table(scl, nr_frags + 1);
        num_sg = skb_to_sgvec(skb, scl, 0, skb->len);
-       num_dma_bufs = dma_map_sg(dev, scl, num_sg, DMA_TO_DEVICE);
+       num_dma_bufs = dma_map_sg(dev, scl, num_sg, DMA_BIDIRECTIONAL);
        if (unlikely(!num_dma_bufs)) {
                err = -ENOMEM;
                goto dma_map_sg_failed;
@@ -406,7 +406,7 @@ static int build_sg_fd(struct dpaa2_eth_priv *priv,
        swa->num_dma_bufs = num_dma_bufs;
 
        /* Separately map the SGT buffer */
-       addr = dma_map_single(dev, sgt_buf, sgt_buf_size, DMA_TO_DEVICE);
+       addr = dma_map_single(dev, sgt_buf, sgt_buf_size, DMA_BIDIRECTIONAL);
        if (unlikely(dma_mapping_error(dev, addr))) {
                err = -ENOMEM;
                goto dma_map_single_failed;
@@ -423,7 +423,7 @@ static int build_sg_fd(struct dpaa2_eth_priv *priv,
 dma_map_single_failed:
        kfree(sgt_buf);
 sgt_buf_alloc_failed:
-       dma_unmap_sg(dev, scl, num_sg, DMA_TO_DEVICE);
+       dma_unmap_sg(dev, scl, num_sg, DMA_BIDIRECTIONAL);
 dma_map_sg_failed:
        kfree(scl);
        return err;
@@ -461,7 +461,7 @@ static int build_single_fd(struct dpaa2_eth_priv *priv,
 
        addr = dma_map_single(dev, buffer_start,
                              skb_tail_pointer(skb) - buffer_start,
-                             DMA_TO_DEVICE);
+                             DMA_BIDIRECTIONAL);
        if (unlikely(dma_mapping_error(dev, addr)))
                return -ENOMEM;
 
@@ -510,7 +510,7 @@ static void free_tx_fd(const struct dpaa2_eth_priv *priv,
                 */
                dma_unmap_single(dev, fd_addr,
                                 skb_tail_pointer(skb) - buffer_start,
-                                DMA_TO_DEVICE);
+                                DMA_BIDIRECTIONAL);
        } else if (fd_format == dpaa2_fd_sg) {
                swa = (struct dpaa2_eth_swa *)skbh;
                skb = swa->skb;
@@ -519,13 +519,13 @@ static void free_tx_fd(const struct dpaa2_eth_priv *priv,
                num_dma_bufs = swa->num_dma_bufs;
 
                /* Unmap the scatterlist */
-               dma_unmap_sg(dev, scl, num_sg, DMA_TO_DEVICE);
+               dma_unmap_sg(dev, scl, num_sg, DMA_BIDIRECTIONAL);
                kfree(scl);
 
                /* Unmap the SGT buffer */
                unmap_size = priv->tx_data_offset +
                       sizeof(struct dpaa2_sg_entry) * (1 + num_dma_bufs);
-               dma_unmap_single(dev, fd_addr, unmap_size, DMA_TO_DEVICE);
+               dma_unmap_single(dev, fd_addr, unmap_size, DMA_BIDIRECTIONAL);
        } else {
                /* Unsupported format, mark it as errored and give up */
                if (status)