mlx4_core: fix mtt range deallocation
authorMarcel Apfelbaum <marcela@mellanox.co.il>
Mon, 2 Jan 2012 04:07:39 +0000 (04:07 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Jan 2012 17:49:16 +0000 (12:49 -0500)
The mtt range was allocated in mtt units but deallocated
in segments. Among the rest, this caused crash during hotplug removal

Reported-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Marcel Apfelbaum <marcela@mellanox.co.il>
Reviewed-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Tested-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/mr.c

index f7243b26bdf5c500ca531d3e7a55e53095a1a22a..01df5567e16e48398c2a119d2c39de060934e712 100644 (file)
@@ -239,8 +239,8 @@ void __mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order)
        first_seg = offset / (1 << log_mtts_per_seg);
 
        mlx4_buddy_free(&mr_table->mtt_buddy, first_seg, seg_order);
-       mlx4_table_put_range(dev, &mr_table->mtt_table, first_seg,
-                            first_seg + (1 << seg_order) - 1);
+       mlx4_table_put_range(dev, &mr_table->mtt_table, offset,
+                            offset + (1 << order) - 1);
 }
 
 static void mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order)