powerpc/qe_lib: Set gpio data before changing the direction to output
authorMichael Barkowski <michaelbarkowski@ruggedcom.com>
Tue, 18 Aug 2009 21:20:44 +0000 (17:20 -0400)
committerKumar Gala <galak@kernel.crashing.org>
Wed, 26 Aug 2009 02:08:45 +0000 (21:08 -0500)
This avoids having a short glitch if the desired initial value is not
the same as what was previously in the data register.

Signed-off-by: Michael Barkowski <michaelbarkowski@ruggedcom.com>
Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
arch/powerpc/sysdev/qe_lib/gpio.c

index 3485288dce31bc6e0b4ad79aa96444ce57bf9afb..8e7a7767dd5c4eacb82be33953df8845126e1d71 100644 (file)
@@ -105,14 +105,14 @@ static int qe_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
        struct qe_gpio_chip *qe_gc = to_qe_gpio_chip(mm_gc);
        unsigned long flags;
 
+       qe_gpio_set(gc, gpio, val);
+
        spin_lock_irqsave(&qe_gc->lock, flags);
 
        __par_io_config_pin(mm_gc->regs, gpio, QE_PIO_DIR_OUT, 0, 0, 0);
 
        spin_unlock_irqrestore(&qe_gc->lock, flags);
 
-       qe_gpio_set(gc, gpio, val);
-
        return 0;
 }