ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Tue, 29 Nov 2011 21:08:00 +0000 (22:08 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 6 Dec 2011 12:27:22 +0000 (13:27 +0100)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ctxfi/ctsrc.c

index e134b3a5780da709d9ccbf3fce4c9f99f7f82fc5..6e77e86307c2c90fd8ca8d3dde53dceebd0499af 100644 (file)
@@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const struct src_desc *desc, struct src **rsrc)
 
        /* Allocate mem for master src resource */
        if (MEMRD == desc->mode)
-               src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL);
+               src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL);
        else
                src = kzalloc(sizeof(*src), GFP_KERNEL);