net: dsa: mv88e6xxx: do not increment bus refcount
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>
Mon, 20 Jun 2016 17:14:01 +0000 (13:14 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jun 2016 07:58:29 +0000 (03:58 -0400)
The MDIO device probe and remove functions are respectively incrementing
and decrementing the bus refcount themselves. Since these bus level
actions are out of the device scope, remove them.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx.c

index b3170ea4959260abdde02bce87ca74699778a895..4b4bffc17d69c48f7deed455c85d062b1a5bb319 100644 (file)
@@ -3712,8 +3712,6 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
        ps->sw_addr = mdiodev->addr;
        mutex_init(&ps->smi_mutex);
 
-       get_device(&ps->bus->dev);
-
        ds->drv = &mv88e6xxx_switch_driver;
 
        id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID);
@@ -3767,7 +3765,6 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
        struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
 
        dsa_unregister_switch(ds);
-       put_device(&ps->bus->dev);
 
        mv88e6xxx_mdio_unregister(ps);
 }