scsi: bnx2i: missing error code in bnx2i_ep_connect()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 23 Jun 2017 07:02:00 +0000 (10:02 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 26 Jun 2017 19:01:03 +0000 (15:01 -0400)
If bnx2i_map_ep_dbell_regs() then we accidentally return NULL instead of
an error pointer.  It results in a NULL dereference in
iscsi_if_ep_connect().

Fixes: cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2i/bnx2i_iscsi.c

index f32a66f89d25b44bd235ca80003040d594020045..03c104b47f31c98670d9a80d64e0b986d707d9f0 100644 (file)
@@ -1909,7 +1909,8 @@ static struct iscsi_endpoint *bnx2i_ep_connect(struct Scsi_Host *shost,
 
        bnx2i_ep_active_list_add(hba, bnx2i_ep);
 
-       if (bnx2i_map_ep_dbell_regs(bnx2i_ep))
+       rc = bnx2i_map_ep_dbell_regs(bnx2i_ep);
+       if (rc)
                goto del_active_ep;
 
        mutex_unlock(&hba->net_dev_lock);