[media] drx-j: don't use mc_info before checking if its not NULL
authorMauro Carvalho Chehab <m.chehab@samsung.com>
Sun, 9 Mar 2014 13:10:19 +0000 (10:10 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 11 Mar 2014 10:37:15 +0000 (07:37 -0300)
smatch warning:
drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code() warn: variable dereferenced before check 'mc_info' (see line 20800)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/dvb-frontends/drx39xyj/drxj.c

index 1e6dab7e5892f8875a069347004e6f05a3320c7b..a8fd53b612ae5f8784678fb2fa76322aa8dffa1b 100644 (file)
@@ -20208,12 +20208,14 @@ static int drx_ctrl_u_code(struct drx_demod_instance *demod,
        const u8 *mc_data_init = NULL;
        u8 *mc_data = NULL;
        unsigned size;
-       char *mc_file = mc_info->mc_file;
+       char *mc_file;
 
        /* Check arguments */
-       if (!mc_info || !mc_file)
+       if (!mc_info || !mc_info->mc_file)
                return -EINVAL;
 
+       mc_file = mc_info->mc_file;
+
        if (!demod->firmware) {
                const struct firmware *fw = NULL;