staging: wlags49_h2: Handle sysfs_create_group return correctly

The function returns 0 on success and non-zero on error. So
correctly record the status so it is freed appropriately.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/staging/wlags49_h2/wl_internal.h b/drivers/staging/wlags49_h2/wl_internal.h
index 6351bb8b680bdb70bf579fd9a08bd9f914fd70ca..9ed28574e8a9ae88aa54b04c3ea2da58a55d2985 100644 (file)
--- a/drivers/staging/wlags49_h2/wl_internal.h
+++ b/drivers/staging/wlags49_h2/wl_internal.h
@@ -883,7 +883,7 @@ struct wl_private
        int                         is_registered;
        int                         is_handling_int;
        int                         firmware_present;
-       char                        sysfsCreated;
+       bool                        sysfsCreated;
        CFG_DRV_INFO_STRCT          driverInfo;
        CFG_IDENTITY_STRCT          driverIdentity;
        CFG_FW_IDENTITY_STRCT       StationIdentity;

diff --git a/drivers/staging/wlags49_h2/wl_sysfs.c b/drivers/staging/wlags49_h2/wl_sysfs.c
index 9b833b30ae6250de88766c86bd38c79b59906600..1508f04b3c6f58a18e7af8c3fe7df519090aa7d3 100644 (file)
--- a/drivers/staging/wlags49_h2/wl_sysfs.c
+++ b/drivers/staging/wlags49_h2/wl_sysfs.c
@@ -120,17 +120,19 @@ static struct attribute_group wlags_group = {
 
 void register_wlags_sysfs(struct net_device *net)
 {
-    struct device *dev = &(net->dev);
-    struct wl_private *lp = wl_priv(net);
-
-    lp->sysfsCreated = sysfs_create_group(&dev->kobj, &wlags_group);
+       struct device *dev = &(net->dev);
+       struct wl_private *lp = wl_priv(net);
+       int err;
+       err = sysfs_create_group(&dev->kobj, &wlags_group);
+       if (!err)
+               lp->sysfsCreated = true;
 }
 
 void unregister_wlags_sysfs(struct net_device *net)
 {
-    struct device *dev = &(net->dev);
-    struct wl_private *lp = wl_priv(net);
+       struct device *dev = &(net->dev);
+       struct wl_private *lp = wl_priv(net);
 
-    if (lp->sysfsCreated)
-       sysfs_remove_group(&dev->kobj, &wlags_group);
+       if (lp->sysfsCreated)
+               sysfs_remove_group(&dev->kobj, &wlags_group);
 }