EDAC: Constify attribute_group structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Mon, 17 Jul 2017 08:20:25 +0000 (10:20 +0200)
committerBorislav Petkov <bp@suse.de>
Mon, 17 Jul 2017 08:20:25 +0000 (10:20 +0200)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
CC: linux-edac@vger.kernel.org
Link: http://lkml.kernel.org/r/776cb8265509054abd01b0b551624cc0da3b88e7.1499078335.git.arvind.yadav.cs@gmail.com
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/edac_mc_sysfs.c
drivers/edac/i7core_edac.c

index 445862dac273982147e7dc0464796fde6e34e129..dbc64469b7da0b977d9ae497062b9925816fec31 100644 (file)
@@ -287,7 +287,7 @@ static struct attribute *csrow_attrs[] = {
        NULL,
 };
 
-static struct attribute_group csrow_attr_grp = {
+static const struct attribute_group csrow_attr_grp = {
        .attrs  = csrow_attrs,
 };
 
@@ -627,7 +627,7 @@ static struct attribute *dimm_attrs[] = {
        NULL,
 };
 
-static struct attribute_group dimm_attr_grp = {
+static const struct attribute_group dimm_attr_grp = {
        .attrs  = dimm_attrs,
 };
 
@@ -902,7 +902,7 @@ static umode_t mci_attr_is_visible(struct kobject *kobj,
        return mode;
 }
 
-static struct attribute_group mci_attr_grp = {
+static const struct attribute_group mci_attr_grp = {
        .attrs  = mci_attrs,
        .is_visible = mci_attr_is_visible,
 };
index 75ad847593b79561dd469273f93109fe68be573a..ba0fa112996f049a37a899b3d94ce74d377cca73 100644 (file)
@@ -1079,7 +1079,7 @@ static struct attribute *i7core_addrmatch_attrs[] = {
        NULL
 };
 
-static struct attribute_group addrmatch_grp = {
+static const struct attribute_group addrmatch_grp = {
        .attrs  = i7core_addrmatch_attrs,
 };
 
@@ -1110,7 +1110,7 @@ static struct attribute *i7core_udimm_counters_attrs[] = {
        NULL
 };
 
-static struct attribute_group all_channel_counts_grp = {
+static const struct attribute_group all_channel_counts_grp = {
        .attrs  = i7core_udimm_counters_attrs,
 };