cpufreq: Throw warning when we try to get policy for an invalid CPU
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 19 Feb 2015 11:32:05 +0000 (17:02 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 7 May 2015 21:29:57 +0000 (23:29 +0200)
Simply returning here with an error is not enough. It shouldn't be allowed at
all to try calling cpufreq_cpu_get() for an invalid CPU.

Add a WARN here to make it clear that it wouldn't be acceptable at all.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Saravana Kannan <skannan@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index ee3d920ae207550edc36b5a55e1a9619689f277e..48ca0764eb520ba913f250dcca6e651d1c005a8c 100644 (file)
@@ -229,7 +229,7 @@ struct cpufreq_policy *cpufreq_cpu_get(unsigned int cpu)
        struct cpufreq_policy *policy = NULL;
        unsigned long flags;
 
-       if (cpu >= nr_cpu_ids)
+       if (WARN_ON(cpu >= nr_cpu_ids))
                return NULL;
 
        if (!down_read_trylock(&cpufreq_rwsem))