Staging: sep: Fix Smatch Warning in sep_crypto.c
authorRashika Kheria <rashika.kheria@gmail.com>
Sat, 19 Oct 2013 10:23:21 +0000 (15:53 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2013 21:51:05 +0000 (14:51 -0700)
This patch fixes the following smatch warning-

~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1137
sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)?
~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1152
sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)?

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sep/sep_crypto.c

index 490a31e0fd4345369028380ef4f94ac3d40b481a..b9262a78dd6edd2e24f6894b5909030262741543 100644 (file)
@@ -1134,7 +1134,7 @@ static int sep_crypto_block_data(struct ablkcipher_request *req)
 
        if (int_error < 0) {
                dev_warn(&ta_ctx->sep_used->pdev->dev, "oddball page error\n");
-               return -ENOMEM;
+               return int_error;
        } else if (int_error == 1) {
                ta_ctx->src_sg = new_sg;
                ta_ctx->src_sg_hold = new_sg;
@@ -1149,7 +1149,7 @@ static int sep_crypto_block_data(struct ablkcipher_request *req)
        if (int_error < 0) {
                dev_warn(&ta_ctx->sep_used->pdev->dev, "walk phys error %x\n",
                        int_error);
-               return -ENOMEM;
+               return int_error;
        } else if (int_error == 1) {
                ta_ctx->dst_sg = new_sg;
                ta_ctx->dst_sg_hold = new_sg;