drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup
authorAlexandru Gheorghiu <gheorghiuandru@gmail.com>
Thu, 16 May 2013 19:04:24 +0000 (14:04 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 16 May 2013 20:49:25 +0000 (13:49 -0700)
Replaced calls to kmalloc followed by strcpy with a sincle call to
kstrdup.  Patch found using coccinelle.

Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/ipmi/ipmi_msghandler.c

index 4d439d2fcfd685a7e3e969aee8d7cef5e1cf14ee..4445fa164a2de5de14330af41847ad2bf1ef1c3d 100644 (file)
@@ -2037,12 +2037,11 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
        entry = kmalloc(sizeof(*entry), GFP_KERNEL);
        if (!entry)
                return -ENOMEM;
-       entry->name = kmalloc(strlen(name)+1, GFP_KERNEL);
+       entry->name = kstrdup(name, GFP_KERNEL);
        if (!entry->name) {
                kfree(entry);
                return -ENOMEM;
        }
-       strcpy(entry->name, name);
 
        file = proc_create_data(name, 0, smi->proc_dir, proc_ops, data);
        if (!file) {