drm/i915: Always call i915_gem_reset_finish() following i915_gem_reset_prepare()
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 12 Feb 2017 17:19:59 +0000 (17:19 +0000)
committerJani Nikula <jani.nikula@intel.com>
Tue, 14 Mar 2017 13:07:38 +0000 (15:07 +0200)
As i915_gem_reset_finish() undoes the steps from
i915_gem_reset_prepare() to leave the system in a fully-working state,
e.g. to be able to free the breadcrumb signal threads, make sure that we
always call it even on the error path.

Fixes: da9a796f5475 ("drm/i915: Split GEM resetting into 3 phases")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170212172002.23072-2-chris@chris-wilson.co.uk
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
(cherry picked from commit 8d613c539c74fa9055f88f4116196d7c820bd98f)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_drv.c

index 6cd78bb2064d838c16288684212feec7c2662db3..1c75402a59c1377e7abd410f2dc58dcec0df7094 100644 (file)
@@ -1809,10 +1809,10 @@ void i915_reset(struct drm_i915_private *dev_priv)
                goto error;
        }
 
-       i915_gem_reset_finish(dev_priv);
        i915_queue_hangcheck(dev_priv);
 
 wakeup:
+       i915_gem_reset_finish(dev_priv);
        enable_irq(dev_priv->drm.irq);
        wake_up_bit(&error->flags, I915_RESET_IN_PROGRESS);
        return;