drm/sti: sti_vtg: Handle return NULL error from devm_ioremap_nocache
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Wed, 21 Dec 2016 05:30:12 +0000 (11:00 +0530)
committerVincent Abriou <vincent.abriou@st.com>
Fri, 6 Jan 2017 14:12:03 +0000 (15:12 +0100)
Here, If devm_ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference. This error check
will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Vincent Abriou <vincent.abriou@st.com>
drivers/gpu/drm/sti/sti_vtg.c

index a8882bdd0f8badf46d0921710dc359cee2f88cde..c3d9c8ae14afeb66b998a59a37b1bdbb60bb87d8 100644 (file)
@@ -429,6 +429,10 @@ static int vtg_probe(struct platform_device *pdev)
                return -ENOMEM;
        }
        vtg->regs = devm_ioremap_nocache(dev, res->start, resource_size(res));
+       if (!vtg->regs) {
+               DRM_ERROR("failed to remap I/O memory\n");
+               return -ENOMEM;
+       }
 
        np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0);
        if (np) {