mmc: jz4740: don't wait for PRG_DONE after stop command with R1 response
authorAlex Smith <alex.smith@imgtec.com>
Tue, 29 Apr 2014 12:54:54 +0000 (13:54 +0100)
committerChris Ball <chris@printf.net>
Mon, 12 May 2014 22:08:22 +0000 (18:08 -0400)
As of commit bcc3e1726d ("mmc: block: Use R1 responses for stop cmds for
read requests"), stop commands for reads do not have MMC_RSP_BUSY set.
In this case we should not wait for a PRG_DONE IRQ after sending the
stop command: it will not get raised when the busy flag is not set,
causing the request to fail with a timeout.

Signed-off-by: Alex Smith <alex.smith@imgtec.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>
Cc: James Hogan <james.hogan@imgtec.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Chris Ball <chris@printf.net>
drivers/mmc/host/jz4740_mmc.c

index de2139cf344477bbe8922448a963c9e1094dd882..537d6c7a5ae48a9458dd3674cf56a975a8331996 100644 (file)
@@ -515,10 +515,13 @@ static irqreturn_t jz_mmc_irq_worker(int irq, void *devid)
 
                jz4740_mmc_send_command(host, req->stop);
 
-               timeout = jz4740_mmc_poll_irq(host, JZ_MMC_IRQ_PRG_DONE);
-               if (timeout) {
-                       host->state = JZ4740_MMC_STATE_DONE;
-                       break;
+               if (mmc_resp_type(req->stop) & MMC_RSP_BUSY) {
+                       timeout = jz4740_mmc_poll_irq(host,
+                                                     JZ_MMC_IRQ_PRG_DONE);
+                       if (timeout) {
+                               host->state = JZ4740_MMC_STATE_DONE;
+                               break;
+                       }
                }
        case JZ4740_MMC_STATE_DONE:
                break;