[PATCH] tipar oops fix
authorDaniel Drake <dsd@gentoo.org>
Fri, 28 Apr 2006 01:39:19 +0000 (18:39 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 28 Apr 2006 15:33:46 +0000 (08:33 -0700)
If compiled into the kernel, parport_register_driver() is called before the
parport driver has been initalised.

This means that it is expected that tp_count is 0 after the
parport_register_driver() call() - tipar's attach function will not be
called until later during bootup.

Signed-off-by: Daniel Drake <dsd@gentoo.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/tipar.c

index eb2eb3e12d6a0ed07a48046e0df136a504342470..079db5a935a1210520d332071d6a47611182dfa4 100644 (file)
@@ -515,7 +515,7 @@ tipar_init_module(void)
                err = PTR_ERR(tipar_class);
                goto out_chrdev;
        }
-       if (parport_register_driver(&tipar_driver) || tp_count == 0) {
+       if (parport_register_driver(&tipar_driver)) {
                printk(KERN_ERR "tipar: unable to register with parport\n");
                err = -EIO;
                goto out_class;