[media] tlg2300: index is unsigned, so never below zero
authorMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 27 Oct 2012 19:23:03 +0000 (16:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 28 Oct 2012 09:38:51 +0000 (07:38 -0200)
drivers/media/usb/tlg2300/pd-video.c:891:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/usb/tlg2300/pd-video.c:926:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Huang Shijie <shijie8@gmail.com>
Cc: Kang Yong <kangyong@telegent.com>
Cc: Zhang Xiaobing <xbzhang@telegent.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/tlg2300/pd-video.c

index 1f448ac7a496c160d567b1b6c2eeb5b4eabff288..3082bfa9b2c5d60fdc38a383344f915564b86e2f 100644 (file)
@@ -888,7 +888,7 @@ static int vidioc_enum_input(struct file *file, void *fh, struct v4l2_input *in)
 {
        struct front_face *front = fh;
 
-       if (in->index < 0 || in->index >= POSEIDON_INPUTS)
+       if (in->index >= POSEIDON_INPUTS)
                return -EINVAL;
        strcpy(in->name, pd_inputs[in->index].name);
        in->type  = V4L2_INPUT_TYPE_TUNER;
@@ -923,7 +923,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int i)
        struct poseidon *pd = front->pd;
        s32 ret, cmd_status;
 
-       if (i < 0 || i >= POSEIDON_INPUTS)
+       if (i >= POSEIDON_INPUTS)
                return -EINVAL;
        ret = send_set_req(pd, SGNL_SRC_SEL,
                        pd_inputs[i].tlg_src, &cmd_status);