net/bridge: fix trivial sparse errors
authorTomas Winkler <tomas.winkler@intel.com>
Mon, 3 Jan 2011 11:08:58 +0000 (11:08 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Jan 2011 21:29:18 +0000 (13:29 -0800)
net/bridge//br_stp_if.c:148:66: warning: conversion of
net/bridge//br_stp_if.c:148:66:     int to
net/bridge//br_stp_if.c:148:66:     int enum umh_wait

net/bridge//netfilter/ebtables.c:1150:30: warning: Using plain integer as NULL pointer

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_stp_if.c
net/bridge/netfilter/ebtables.c

index 1d8826914cbf20a7fecec51bffeee3551a61e7e4..79372d4a40551f92b2841b2c8008dcf29c89b38a 100644 (file)
@@ -145,7 +145,7 @@ static void br_stp_stop(struct net_bridge *br)
        char *envp[] = { NULL };
 
        if (br->stp_enabled == BR_USER_STP) {
-               r = call_usermodehelper(BR_STP_PROG, argv, envp, 1);
+               r = call_usermodehelper(BR_STP_PROG, argv, envp, UMH_WAIT_PROC);
                br_info(br, "userspace STP stopped, return code %d\n", r);
 
                /* To start timers on any ports left in blocking */
index cbc9f395ab1ed1119bf51f460c992b1b2e315e30..16df0532d4b9a7d5ff41c3f1e1df889d204128a0 100644 (file)
@@ -1147,7 +1147,7 @@ ebt_register_table(struct net *net, const struct ebt_table *input_table)
        void *p;
 
        if (input_table == NULL || (repl = input_table->table) == NULL ||
-           repl->entries == 0 || repl->entries_size == 0 ||
+           repl->entries == NULL || repl->entries_size == 0 ||
            repl->counters != NULL || input_table->private != NULL) {
                BUGPRINT("Bad table data for ebt_register_table!!!\n");
                return ERR_PTR(-EINVAL);