driver: ipvlan: Unlink the upper dev when ipvlan_link_new failed
authorGao Feng <fgao@ikuai8.com>
Thu, 8 Dec 2016 03:16:58 +0000 (11:16 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Dec 2016 19:30:07 +0000 (14:30 -0500)
When netdev_upper_dev_unlink failed in ipvlan_link_new, need to
unlink the ipvlan dev with upper dev.

Signed-off-by: Gao Feng <fgao@ikuai8.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipvlan/ipvlan_main.c

index 0fef17874d5031f48f186b639763a3b09b446d2e..dfbc4ef6d507b09905f5f9f57717acdebaaa53be 100644 (file)
@@ -546,13 +546,15 @@ static int ipvlan_link_new(struct net *src_net, struct net_device *dev,
        }
        err = ipvlan_set_port_mode(port, mode);
        if (err) {
-               goto unregister_netdev;
+               goto unlink_netdev;
        }
 
        list_add_tail_rcu(&ipvlan->pnode, &port->ipvlans);
        netif_stacked_transfer_operstate(phy_dev, dev);
        return 0;
 
+unlink_netdev:
+       netdev_upper_dev_unlink(phy_dev, dev);
 unregister_netdev:
        unregister_netdevice(dev);
 destroy_ipvlan_port: