ALSA: hda/realtek: Fix pop noise on ALC225
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Wed, 11 Mar 2020 06:13:28 +0000 (14:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2020 14:34:22 +0000 (16:34 +0200)
commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 upstream.

Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
0") makes the ALC225 have pop noise on S3 resume and cold boot.

So partially revert this commit for ALC225 to fix the regression.

Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
BugLink: https://bugs.launchpad.net/bugs/1866357
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/patch_realtek.c

index 5a7afbeb612d59037e5fe320d1b84122f2ba13c3..b500dad33ea9ef72ddb7e91b19917599530566a1 100644 (file)
@@ -4687,6 +4687,8 @@ static void alc_determine_headset_type(struct hda_codec *codec)
                is_ctia = (val & 0x1c02) == 0x1c02;
                break;
        case 0x10ec0225:
+               codec->power_save_node = 1;
+               /* fall through */
        case 0x10ec0295:
        case 0x10ec0299:
                alc_process_coef_fw(codec, alc225_pre_hsmode);