projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f81e5ca)
net: ethernet: aquantia: return -ETIME in macro AQ_HW_WAIT_FOR
authorColin Ian King <colin.king@canonical.com>
Fri, 27 Jan 2017 15:06:46 +0000 (15:06 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Jan 2017 23:24:00 +0000 (18:24 -0500)
The macro is returning ETIME which means various checks to see if
the returned err is less than zero never work. I believe a -ETIME
should be returned instead.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h patch | blob | blame | history

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h
index 78fcc0c3ab4d314b65c9156f3b734e5d85216caa..03b72ddbffb9803e013e7b20738d6cb29ac2005c 100644 (file)
--- a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h
@@ -31,7 +31,7 @@ do { \
                udelay(_US_); \
        } \
        if (!AQ_HW_WAIT_FOR_i) {\
-               err = ETIME; \
+               err = -ETIME; \
        } \
 } while (0)