ath9k: Fix ath_startrecv()
authorSujith Manoharan <c_manoha@qca.qualcomm.com>
Fri, 5 Sep 2014 02:33:16 +0000 (08:03 +0530)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 9 Sep 2014 19:27:21 +0000 (15:27 -0400)
Since ath_startrecv() doesn't return an error value,
cleanup the callsites.

Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/ath9k.h
drivers/net/wireless/ath/ath9k/main.c
drivers/net/wireless/ath/ath9k/recv.c

index b4ac51e701237415a5b0133da41d0ede790109a9..12cdabbfb8da1f9944b737ddbea7b619804d8f8e 100644 (file)
@@ -527,7 +527,7 @@ static inline void ath_chanctx_check_active(struct ath_softc *sc,
 #endif /* CONFIG_ATH9K_CHANNEL_CONTEXT */
 
 int ath_reset_internal(struct ath_softc *sc, struct ath9k_channel *hchan);
-int ath_startrecv(struct ath_softc *sc);
+void ath_startrecv(struct ath_softc *sc);
 bool ath_stoprecv(struct ath_softc *sc);
 u32 ath_calcrxfilter(struct ath_softc *sc);
 int ath_rx_init(struct ath_softc *sc, int nbufs);
index 5d9f4d738d7417563e473c372e6a62132bc1f182..18e5e91cf7c9549c73b00f6fb60be1c0a7d0b128 100644 (file)
@@ -225,15 +225,9 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start)
        unsigned long flags;
 
        ath9k_calculate_summary_state(sc, sc->cur_chan);
-
-       if (ath_startrecv(sc) != 0) {
-               ath_err(common, "Unable to restart recv logic\n");
-               return false;
-       }
-
+       ath_startrecv(sc);
        ath9k_cmn_update_txpow(ah, sc->curtxpow,
                               sc->cur_chan->txpower, &sc->curtxpow);
-
        clear_bit(ATH_OP_HW_RESET, &common->op_flags);
 
        if (!sc->cur_chan->offchannel && start) {
index 2aaf233ee5d68cf7e937538c2ab3d211152f90bb..04b02b56076f195b642e3d1f300502e137d3021b 100644 (file)
@@ -433,14 +433,14 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
 
 }
 
-int ath_startrecv(struct ath_softc *sc)
+void ath_startrecv(struct ath_softc *sc)
 {
        struct ath_hw *ah = sc->sc_ah;
        struct ath_rxbuf *bf, *tbf;
 
        if (ah->caps.hw_caps & ATH9K_HW_CAP_EDMA) {
                ath_edma_start_recv(sc);
-               return 0;
+               return;
        }
 
        if (list_empty(&sc->rx.rxbuf))
@@ -463,8 +463,6 @@ int ath_startrecv(struct ath_softc *sc)
 start_recv:
        ath_opmode_init(sc);
        ath9k_hw_startpcureceive(ah, sc->cur_chan->offchannel);
-
-       return 0;
 }
 
 static void ath_flushrecv(struct ath_softc *sc)