projects / GitHub / LineageOS / android_kernel_samsung_universal7580.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 9be4844)
hwmon: (f75375s) fix pwm mode setting
authorRiku Voipio <riku.voipio@iki.fi>
Thu, 18 Oct 2007 13:29:53 +0000 (09:29 -0400)
committerMark M. Hoffman <mhoffman@lightlink.com>
Thu, 8 Nov 2007 13:42:46 +0000 (08:42 -0500)
Spotted by the Coverity checker. (Thanks Adrian Bunk)

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
drivers/hwmon/f75375s.c patch | blob | blame | history

diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index 13a041326a04643c63324357acb2c9e4e45e65d7..59a3470d6cf99b30ff4cce23fe14083110ede9f9 100644 (file)
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -323,7 +323,7 @@ static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
        int val = simple_strtoul(buf, NULL, 10);
        u8 conf = 0;
 
-       if (val != 0 || val != 1 || data->kind == f75373)
+       if (!(val == 0 || val == 1) || data->kind == f75373)
                return -EINVAL;
 
        mutex_lock(&data->update_lock);