drm/i915: add MISSING_CASE annotation to ibx_digital_port_connected
authorJani Nikula <jani.nikula@intel.com>
Thu, 20 Aug 2015 07:47:38 +0000 (10:47 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 26 Aug 2015 09:00:33 +0000 (11:00 +0200)
With the case added for eDP on port A (always connected from this
function's point of view), we should not be hitting any of the default
cases in ibx_digital_port_connected, so add MISSING_CASE annotation.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Durgadoss R <durgadoss.r@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index be53e36499b867153b5537ff7d6168b9a5bbb84b..8c8070ee26d756db50d26eca2a2ff5a6eeb4e515 100644 (file)
@@ -4494,6 +4494,8 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
 
        if (HAS_PCH_IBX(dev_priv->dev)) {
                switch (port->port) {
+               case PORT_A:
+                       return true;
                case PORT_B:
                        bit = SDE_PORTB_HOTPLUG;
                        break;
@@ -4504,10 +4506,13 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
                        bit = SDE_PORTD_HOTPLUG;
                        break;
                default:
-                       return true;
+                       MISSING_CASE(port->port);
+                       return false;
                }
        } else {
                switch (port->port) {
+               case PORT_A:
+                       return true;
                case PORT_B:
                        bit = SDE_PORTB_HOTPLUG_CPT;
                        break;
@@ -4518,7 +4523,8 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
                        bit = SDE_PORTD_HOTPLUG_CPT;
                        break;
                default:
-                       return true;
+                       MISSING_CASE(port->port);
+                       return false;
                }
        }