i40e: Fix for unused value issue found by static analysis

This patch fixes an issue where an error return value is
set, but without an immediate exit, the value can be overwritten
by the following code execution.  The condition  at this point
is not fatal, so remove the error assignment and comment the
intent for future code maintainers

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 5a06cd23b9e622837e5d63b6e2458673e09dbd62..0962b85ef6f3fc8e41e124241d19159702d05e6e 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -9884,13 +9884,15 @@ static int i40e_add_vsi(struct i40e_vsi *vsi)
                         */
                        ret = i40e_vsi_config_tc(vsi, enabled_tc);
                        if (ret) {
+                               /* Single TC condition is not fatal,
+                                * message and continue
+                                */
                                dev_info(&pf->pdev->dev,
                                         "failed to configure TCs for main VSI tc_map 0x%08x, err %s aq_err %s\n",
                                         enabled_tc,
                                         i40e_stat_str(&pf->hw, ret),
                                         i40e_aq_str(&pf->hw,
                                                    pf->hw.aq.asq_last_status));
-                               ret = -ENOENT;
                        }
                }
                break;