NFC: NCI: Don't reverse local general bytes
authorAmitkumar Karwar <akarwar@marvell.com>
Mon, 6 Jan 2014 20:58:15 +0000 (12:58 -0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Tue, 7 Jan 2014 00:32:40 +0000 (01:32 +0100)
Local general bytes returned by nfc_get_local_general_bytes()
are already in correct order. We don't need to reverse them.

Remove local_gb[] local array as it's not needed any more.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/nci/core.c

index 0a2ee83c3bd3363eacca540f0b95977d4329d341..6fbb7bab46e719f2193037911dbe9bf49a5926d6 100644 (file)
@@ -414,8 +414,6 @@ static int nci_set_local_general_bytes(struct nfc_dev *nfc_dev)
 {
        struct nci_dev *ndev = nfc_get_drvdata(nfc_dev);
        struct nci_set_config_param param;
-       __u8 local_gb[NFC_MAX_GT_LEN];
-       int i;
 
        param.val = nfc_get_local_general_bytes(nfc_dev, &param.len);
        if ((param.val == NULL) || (param.len == 0))
@@ -424,11 +422,7 @@ static int nci_set_local_general_bytes(struct nfc_dev *nfc_dev)
        if (param.len > NFC_MAX_GT_LEN)
                return -EINVAL;
 
-       for (i = 0; i < param.len; i++)
-               local_gb[param.len-1-i] = param.val[i];
-
        param.id = NCI_PN_ATR_REQ_GEN_BYTES;
-       param.val = local_gb;
 
        return nci_request(ndev, nci_set_config_req, (unsigned long)&param,
                           msecs_to_jiffies(NCI_SET_CONFIG_TIMEOUT));