[PATCH] Fix error recovery path for arch_setup_additional_pages
authorRoland McGrath <roland@redhat.com>
Thu, 28 Apr 2005 22:17:19 +0000 (15:17 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Thu, 28 Apr 2005 22:17:19 +0000 (15:17 -0700)
If arch_setup_additional_pages fails, the error path will do some double-frees.
This fixes it.

Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/binfmt_elf.c

index 6ae62cbf7c2e5ccd083aaea4648c47a04acb9059..ce9423bb2de319d095a3ac5d8e762dcd6d8b3913 100644 (file)
@@ -945,7 +945,7 @@ static int load_elf_binary(struct linux_binprm * bprm, struct pt_regs * regs)
        retval = arch_setup_additional_pages(bprm, executable_stack);
        if (retval < 0) {
                send_sig(SIGKILL, current, 0);
-               goto out_free_dentry;
+               goto out;
        }
 #endif /* ARCH_HAS_SETUP_ADDITIONAL_PAGES */