gpu: host1x: Don't fail on NULL bo physical address
authorMikko Perttunen <mperttunen@nvidia.com>
Wed, 2 Aug 2017 09:55:04 +0000 (12:55 +0300)
committerThierry Reding <treding@nvidia.com>
Thu, 17 Aug 2017 15:57:06 +0000 (17:57 +0200)
Pinning a Host1x BO currently cannot fail and zero is a valid address
for a BO when IOMMU is enabled. To avoid false errors remove checks
for NULL BO physical addresses.

Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support")
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/host1x/job.c

index bee504406cfc4c3a7a5eba917ad51dce59d8adda..db509ab8874e58fd1f798da270fa8035ed4563d3 100644 (file)
@@ -197,10 +197,6 @@ static unsigned int pin_job(struct host1x *host, struct host1x_job *job)
                }
 
                phys_addr = host1x_bo_pin(reloc->target.bo, &sgt);
-               if (!phys_addr) {
-                       err = -EINVAL;
-                       goto unpin;
-               }
 
                job->addr_phys[job->num_unpins] = phys_addr;
                job->unpins[job->num_unpins].bo = reloc->target.bo;
@@ -225,10 +221,6 @@ static unsigned int pin_job(struct host1x *host, struct host1x_job *job)
                }
 
                phys_addr = host1x_bo_pin(g->bo, &sgt);
-               if (!phys_addr) {
-                       err = -EINVAL;
-                       goto unpin;
-               }
 
                if (!IS_ENABLED(CONFIG_TEGRA_HOST1X_FIREWALL) && host->domain) {
                        for_each_sg(sgt->sgl, sg, sgt->nents, j)