ipv4: fib_select_default should match the prefix
authorJulian Anastasov <ja@ssi.bg>
Wed, 22 Jul 2015 07:43:22 +0000 (10:43 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Jul 2015 05:46:09 +0000 (22:46 -0700)
fib_trie starting from 4.1 can link fib aliases from
different prefixes in same list. Make sure the alternative
gateways are in same table and for same prefix (0) by
checking tb_id and fa_slen.

Fixes: 79e5ad2ceb00 ("fib_trie: Remove leaf_info")
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c

index c7358ea4ae93530a7f6ef110a2dc204f19ac830e..e1079583b8b7fa41c1f1297eefe3b4481e35b11c 100644 (file)
@@ -1207,12 +1207,17 @@ void fib_select_default(struct fib_result *res)
        struct fib_info *fi = NULL, *last_resort = NULL;
        struct hlist_head *fa_head = res->fa_head;
        struct fib_table *tb = res->table;
+       u8 slen = 32 - res->prefixlen;
        int order = -1, last_idx = -1;
        struct fib_alias *fa;
 
        hlist_for_each_entry_rcu(fa, fa_head, fa_list) {
                struct fib_info *next_fi = fa->fa_info;
 
+               if (fa->fa_slen != slen)
+                       continue;
+               if (fa->tb_id != tb->tb_id)
+                       continue;
                if (next_fi->fib_scope != res->scope ||
                    fa->fa_type != RTN_UNICAST)
                        continue;