sparc64: vcc: Fix error return code in vcc_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 27 Apr 2020 12:24:15 +0000 (12:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Oct 2020 11:12:42 +0000 (13:12 +0200)
[ Upstream commit ff62255a2a5c1228a28f2bb063646f948115a309 ]

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200427122415.47416-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/vcc.c

index ef01d24858cd659b9d667c964536fe6798bde6bb..4e795353192bc7b9e236902f352fdb91b1f68c8e 100644 (file)
@@ -612,6 +612,7 @@ static int vcc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
        port->index = vcc_table_add(port);
        if (port->index == -1) {
                pr_err("VCC: no more TTY indices left for allocation\n");
+               rv = -ENOMEM;
                goto free_ldc;
        }