ubifs: dereferencing an ERR_PTR in ubifs_mount()
authorDan Carpenter <error27@gmail.com>
Mon, 20 Jun 2011 07:10:24 +0000 (10:10 +0300)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 20 Jun 2011 14:42:34 +0000 (10:42 -0400)
d251ed271d5 "ubifs: fix sget races" left out the goto from this
error path so the static checkers complain that we're dereferencing
"sb" when it's an ERR_PTR.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ubifs/super.c

index 8c892c2d5300f2d6a44e8faf481b14ecb904d9fe..529be058202938cf1226ec8644401951df8ab032 100644 (file)
@@ -2146,6 +2146,7 @@ static struct dentry *ubifs_mount(struct file_system_type *fs_type, int flags,
        if (IS_ERR(sb)) {
                err = PTR_ERR(sb);
                kfree(c);
+               goto out_close;
        }
 
        if (sb->s_root) {