ixgbe: remove redundant if clause from PTP work
authorJakub Kicinski <kubakici@wp.pl>
Sat, 15 Mar 2014 14:55:11 +0000 (14:55 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 31 Mar 2014 22:48:00 +0000 (15:48 -0700)
ptp_tx_skb is always set before work is scheduled,
work is cancelled before ptp_tx_skb is set to NULL.
PTP work cannot ever see ptp_tx_skb set to NULL.

Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c

index 44ac9aef6a8d51d0371368525c4038e5faa0b2e1..8b527d79d429ea02c649965681acc1951861355b 100644 (file)
@@ -512,10 +512,6 @@ static void ixgbe_ptp_tx_hwtstamp_work(struct work_struct *work)
                                              IXGBE_PTP_TX_TIMEOUT);
        u32 tsynctxctl;
 
-       /* we have to have a valid skb */
-       if (!adapter->ptp_tx_skb)
-               return;
-
        if (timeout) {
                dev_kfree_skb_any(adapter->ptp_tx_skb);
                adapter->ptp_tx_skb = NULL;