openvswitch: Use net_ratelimit in OVS_NLERR
authorJoe Perches <joe@perches.com>
Tue, 4 Feb 2014 01:06:46 +0000 (17:06 -0800)
committerJesse Gross <jesse@nicira.com>
Fri, 16 May 2014 20:40:28 +0000 (13:40 -0700)
Each use of pr_<level>_once has a per-site flag.

Some of the OVS_NLERR messages look as if seeing them
multiple times could be useful, so use net_ratelimit()
instead of pr_info_once.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
net/openvswitch/datapath.h

index 05317380fc03a03af708716f162738727cab5fff..7ede507500d7daa1cca3d352f9923122f5e63709 100644 (file)
@@ -194,7 +194,9 @@ struct sk_buff *ovs_vport_cmd_build_info(struct vport *, u32 pid, u32 seq,
 int ovs_execute_actions(struct datapath *dp, struct sk_buff *skb);
 void ovs_dp_notify_wq(struct work_struct *work);
 
-#define OVS_NLERR(fmt, ...) \
-       pr_info_once("netlink: " fmt, ##__VA_ARGS__)
-
+#define OVS_NLERR(fmt, ...)                                    \
+do {                                                           \
+       if (net_ratelimit())                                    \
+               pr_info("netlink: " fmt, ##__VA_ARGS__);        \
+} while (0)
 #endif /* datapath.h */