mac80211: cancel scan in ieee80211_restart_hw if software scan pending
authorJohn W. Linville <linville@tuxdriver.com>
Mon, 30 Aug 2010 19:12:02 +0000 (15:12 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 31 Aug 2010 19:20:45 +0000 (15:20 -0400)
This function exists to clean-up after a hardware error or something
similar.  The restart is accomplished using the same infrastructure used
to resume after a suspend.  The suspend path cancels running scans, so
it seems appropriate to do that here as well for software-based scans.
If a hardware-based scan is pending, issue a warning message since this
indicates that the drivers has failed to clean-up after itself.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/main.c

index 93194f61adb0cc16e820fc6893abb0ccd112ac9e..a06b6ee63c07d7ac64f2440dba3fcf4b8fd40daa 100644 (file)
@@ -305,7 +305,13 @@ void ieee80211_restart_hw(struct ieee80211_hw *hw)
 
        trace_api_restart_hw(local);
 
-       /* use this reason, __ieee80211_resume will unblock it */
+       WARN(test_bit(SCAN_HW_SCANNING, &local->scanning),
+               "%s called with hardware scan in progress\n", __func__);
+
+       if (unlikely(test_bit(SCAN_SW_SCANNING, &local->scanning)))
+               ieee80211_scan_cancel(local);
+
+       /* use this reason, ieee80211_reconfig will unblock it */
        ieee80211_stop_queues_by_reason(hw,
                IEEE80211_QUEUE_STOP_REASON_SUSPEND);