clk: aggregate return codes of notify chains
authorPeter De Schrijver <pdeschrijver@nvidia.com>
Tue, 21 Mar 2017 10:16:26 +0000 (12:16 +0200)
committerMichael Turquette <mturquette@baylibre.com>
Wed, 12 Apr 2017 16:51:41 +0000 (18:51 +0200)
In case there are multiple notify chains for the same clocks (because they
were registered by different users), we need to propagate potential failure
of any single one of them to the caller. Otherwise we eg risk violating the
V/f curve when a notifier is used for DVFS.

Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michael Turquette <mturquette@baylibre.com>
drivers/clk/clk.c

index 0d8eb5aa477aeb51bd4e56793ccaf2d84495afb4..cddddbe46d9d976132785cd2e7ba530ee437e096 100644 (file)
@@ -966,6 +966,8 @@ static int __clk_notify(struct clk_core *core, unsigned long msg,
                        cnd.clk = cn->clk;
                        ret = srcu_notifier_call_chain(&cn->notifier_head, msg,
                                        &cnd);
+                       if (ret & NOTIFY_STOP_MASK)
+                               return ret;
                }
        }