[S390] etr/stp: fix possible deadlock
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Fri, 23 Jan 2009 15:40:26 +0000 (16:40 +0100)
committerHeiko Carstens <heiko.carstens@de.ibm.com>
Fri, 23 Jan 2009 15:40:29 +0000 (16:40 +0100)
Precreate stop_machine threads in case the machine supports ETR/STP.
Otherwise we might deadlock if a time sync operation gets scheduled
and the creation of stop_machine threads would cause disk I/O.
This is just the minimal fix.
The real fix would be to only precreate stop_machine threads if
ETR/STP is actually used. But that would be a rather large and
complicated patch.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
arch/s390/kernel/time.c

index d649600df5b9a887c17f6770ad878e8820c51d92..fc468cae4460ace449d92250f777f70490a25380 100644 (file)
@@ -399,8 +399,10 @@ static struct workqueue_struct *time_sync_wq;
 
 static void __init time_init_wq(void)
 {
-       if (!time_sync_wq)
-               time_sync_wq = create_singlethread_workqueue("timesync");
+       if (time_sync_wq)
+               return;
+       time_sync_wq = create_singlethread_workqueue("timesync");
+       stop_machine_create();
 }
 
 /*