staging: vt6655: replace typedef struct tagSRTS_g with struct vnt_rts_g
authorMalcolm Priestley <tvboxspy@gmail.com>
Sat, 30 Aug 2014 21:25:41 +0000 (22:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 22:19:16 +0000 (15:19 -0700)
Replacing members
b, a, wDuration_ba, wDuration_aa, wDuration_bb, wReserved and data
with
b, a,duration_ba, duration_aa, duration_bb, reserved and  data

replacing unsigned short with u16 or __le16 where endian correction is necessary.

Creating the new structure in rxtx.h

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/desc.h
drivers/staging/vt6655/rxtx.c
drivers/staging/vt6655/rxtx.h

index 00c3922e3ec2775c3d6424e4c9cd5cda0f5dc8b9..5fbef74f3e21a8edb797b58cf20666fc2ef5ae21 100644 (file)
@@ -352,18 +352,6 @@ union vnt_phy_field_swap {
        u32 field_write;
 };
 
-typedef struct tagSRTS_g {
-       struct vnt_phy_field b;
-       struct vnt_phy_field a;
-       unsigned short wDuration_ba;
-       unsigned short wDuration_aa;
-       unsigned short wDuration_bb;
-       unsigned short wReserved;
-       struct ieee80211_rts data;
-} __attribute__ ((__packed__))
-SRTS_g, *PSRTS_g;
-typedef const SRTS_g *PCSRTS_g;
-
 typedef struct tagSRTS_g_FB {
        struct vnt_phy_field b;
        struct vnt_phy_field a;
index d94d4964c60710fd7e5edd1dcaf978b93b39b7c2..29a4ed06b8faa7e0d54955752d0561391a118266 100644 (file)
@@ -818,37 +818,46 @@ s_vFillRTSHead(
        //       Otherwise, we need to modify codes for them.
        if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {
                if (byFBOption == AUTO_FB_NONE) {
-                       PSRTS_g pBuf = (PSRTS_g)pvRTS;
+                       struct vnt_rts_g *buf = pvRTS;
                        /* Get SignalField, ServiceField & Length */
                        vnt_get_phy_field(pDevice, uRTSFrameLen,
                                          pDevice->byTopCCKBasicRate,
-                                         PK_TYPE_11B, &pBuf->b);
+                                         PK_TYPE_11B, &buf->b);
 
                        vnt_get_phy_field(pDevice, uRTSFrameLen,
                                          pDevice->byTopOFDMBasicRate,
-                                         byPktType, &pBuf->a);
-                       //Get Duration
-                       pBuf->wDuration_bb = cpu_to_le16((unsigned short)s_uGetRTSCTSDuration(pDevice, RTSDUR_BB, cbFrameLength, PK_TYPE_11B, pDevice->byTopCCKBasicRate, bNeedAck, byFBOption));    //0:RTSDuration_bb, 1:2.4G, 1:CCKData
-                       pBuf->wDuration_aa = cpu_to_le16((unsigned short)s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption)); //2:RTSDuration_aa, 1:2.4G, 2,3: 2.4G OFDMData
-                       pBuf->wDuration_ba = cpu_to_le16((unsigned short)s_uGetRTSCTSDuration(pDevice, RTSDUR_BA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption)); //1:RTSDuration_ba, 1:2.4G, 2,3:2.4G OFDM Data
-
-                       pBuf->data.duration = pBuf->wDuration_aa;
+                                         byPktType, &buf->a);
+                       /* Get Duration */
+                       buf->duration_bb =
+                               cpu_to_le16((u16)s_uGetRTSCTSDuration(pDevice, RTSDUR_BB, cbFrameLength,
+                                                                     PK_TYPE_11B, pDevice->byTopCCKBasicRate,
+                                                                     bNeedAck, byFBOption));
+                       buf->duration_aa =
+                               cpu_to_le16((u16)s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, cbFrameLength,
+                                                                     byPktType, wCurrentRate, bNeedAck,
+                                                                     byFBOption));
+                       buf->duration_ba =
+                               cpu_to_le16((u16)s_uGetRTSCTSDuration(pDevice, RTSDUR_BA, cbFrameLength,
+                                                                     byPktType, wCurrentRate, bNeedAck,
+                                                                     byFBOption));
+
+                       buf->data.duration = buf->duration_aa;
                        /* Get RTS Frame body */
-                       pBuf->data.frame_control =
+                       buf->data.frame_control =
                                        cpu_to_le16(IEEE80211_FTYPE_CTL |
                                                    IEEE80211_STYPE_RTS);
 
 
                        if ((pDevice->eOPMode == OP_MODE_ADHOC) ||
                            (pDevice->eOPMode == OP_MODE_AP)) {
-                               memcpy(&pBuf->data.ra, psEthHeader->abyDstAddr, ETH_ALEN);
+                               memcpy(&buf->data.ra, psEthHeader->abyDstAddr, ETH_ALEN);
                        } else {
-                               memcpy(&pBuf->data.ra, pDevice->abyBSSID, ETH_ALEN);
+                               memcpy(&buf->data.ra, pDevice->abyBSSID, ETH_ALEN);
                        }
                        if (pDevice->eOPMode == OP_MODE_AP)
-                               memcpy(&pBuf->data.ta, pDevice->abyBSSID, ETH_ALEN);
+                               memcpy(&buf->data.ta, pDevice->abyBSSID, ETH_ALEN);
                        else
-                               memcpy(&pBuf->data.ta, psEthHeader->abySrcAddr, ETH_ALEN);
+                               memcpy(&buf->data.ta, psEthHeader->abySrcAddr, ETH_ALEN);
 
                } else {
                        PSRTS_g_FB pBuf = (PSRTS_g_FB)pvRTS;
@@ -1335,11 +1344,13 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
                        if (bRTS == true) {//RTS_need
                                pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
                                pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
-                               pvRTS = (PSRTS_g)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
+                               pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
                                pvCTS = NULL;
-                               pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(SRTS_g));
+                               pvTxDataHd = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) +
+                                                       cbMICHDR + sizeof(struct vnt_rts_g));
                                cbHeaderLength = wTxBufSize + sizeof(struct vnt_rrv_time_rts) +
-                                                       cbMICHDR + sizeof(SRTS_g) + sizeof(struct vnt_tx_datahead_g);
+                                                       cbMICHDR + sizeof(struct vnt_rts_g) +
+                                                       sizeof(struct vnt_tx_datahead_g);
                        } else { //RTS_needless
                                pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
                                pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts));
index 21bbc7e4ef08b2141ae219dc9112461194bc487d..377cd42ab56a90ed8a86fff97023c64aed8b19a0 100644 (file)
@@ -113,6 +113,17 @@ struct vnt_tx_datahead_a_fb {
        __le16 duration_f1;
 } __packed;
 
+/* RTS buffer header */
+struct vnt_rts_g {
+       struct vnt_phy_field b;
+       struct vnt_phy_field a;
+       __le16 duration_ba;
+       __le16 duration_aa;
+       __le16 duration_bb;
+       u16 reserved;
+       struct ieee80211_rts data;
+} __packed;
+
 struct vnt_tx_short_buf_head {
        __le16 fifo_ctl;
        u16 time_stamp;