gpio: mcp23s08: Add support for level triggered interrupts

The interrupt for the corresponding pin is configured to trigger when the
pin state changes compared to a preconfigured state (Bit set in INTCON).
This state is set by setting/clearing the bit in DEFVAL.
In the interrupt handler we need also to check if the bit in INTCON is set
for level triggered interrupts.

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index c882c2be5a0e954fa210bb6f3f3ccd4e1b444cc4..ac22efc1840ee020f750359b13239ff59d1b20dc 100644 (file)
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -362,7 +362,8 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
        for (i = 0; i < mcp->chip.ngpio; i++) {
                if ((BIT(i) & mcp->cache[MCP_INTF]) &&
                    ((BIT(i) & intcap & mcp->irq_rise) ||
-                    (mcp->irq_fall & ~intcap & BIT(i)))) {
+                    (mcp->irq_fall & ~intcap & BIT(i)) ||
+                    (BIT(i) & mcp->cache[MCP_INTCON]))) {
                        child_irq = irq_find_mapping(mcp->chip.irqdomain, i);
                        handle_nested_irq(child_irq);
                }
@@ -408,6 +409,12 @@ static int mcp23s08_irq_set_type(struct irq_data *data, unsigned int type)
                mcp->cache[MCP_INTCON] &= ~BIT(pos);
                mcp->irq_rise &= ~BIT(pos);
                mcp->irq_fall |= BIT(pos);
+       } else if (type & IRQ_TYPE_LEVEL_HIGH) {
+               mcp->cache[MCP_INTCON] |= BIT(pos);
+               mcp->cache[MCP_DEFVAL] &= ~BIT(pos);
+       } else if (type & IRQ_TYPE_LEVEL_LOW) {
+               mcp->cache[MCP_INTCON] |= BIT(pos);
+               mcp->cache[MCP_DEFVAL] |= BIT(pos);
        } else
                return -EINVAL;