KVM: Fix userspace IRQ chip migration
authorGleb Natapov <gleb@redhat.com>
Tue, 21 Apr 2009 14:45:10 +0000 (17:45 +0300)
committerAvi Kivity <avi@redhat.com>
Wed, 10 Jun 2009 08:48:48 +0000 (11:48 +0300)
Re-put pending IRQ vector into interrupt_bitmap before migration.
Otherwise it will be lost if migration happens in the wrong time.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/x86.c

index 96e995c1dd76d12989cdcbf17596847005664dcb..63917216a051b27e8a8be172bca48d1d87a51026 100644 (file)
@@ -3566,17 +3566,17 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
        sregs->efer = vcpu->arch.shadow_efer;
        sregs->apic_base = kvm_get_apic_base(vcpu);
 
-       if (irqchip_in_kernel(vcpu->kvm)) {
+       if (irqchip_in_kernel(vcpu->kvm))
                memset(sregs->interrupt_bitmap, 0,
                       sizeof sregs->interrupt_bitmap);
-               pending_vec = kvm_x86_ops->get_irq(vcpu);
-               if (pending_vec >= 0)
-                       set_bit(pending_vec,
-                               (unsigned long *)sregs->interrupt_bitmap);
-       } else
+       else
                memcpy(sregs->interrupt_bitmap, vcpu->arch.irq_pending,
                       sizeof sregs->interrupt_bitmap);
 
+       pending_vec = kvm_x86_ops->get_irq(vcpu);
+       if (pending_vec >= 0)
+               set_bit(pending_vec, (unsigned long *)sregs->interrupt_bitmap);
+
        vcpu_put(vcpu);
 
        return 0;