qede: Fix forcing high speeds
authorYuval Mintz <Yuval.Mintz@qlogic.com>
Fri, 19 Aug 2016 05:34:58 +0000 (08:34 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Aug 2016 06:04:40 +0000 (23:04 -0700)
While '0xdead' and '0xbeef' are "great" values, we should
use the correct SPEED_* values instead.

Fixes: 054c67d1c82a ("qed*: Add support for ethtool link_ksettings callbacks")
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_ethtool.c

index 51782bf4987f5ae9ca8bc98e93c15f6a937e8bd5..f6b8899cda7f7162186bf99874f9e0cda9ae3046 100644 (file)
@@ -414,7 +414,7 @@ static int qede_set_link_ksettings(struct net_device *dev,
                        }
                        params.adv_speeds = QED_LM_40000baseLR4_Full_BIT;
                        break;
-               case 0xdead:
+               case SPEED_50000:
                        if (!(current_link.supported_caps &
                              QED_LM_50000baseKR2_Full_BIT)) {
                                DP_INFO(edev, "50G speed not supported\n");
@@ -422,7 +422,7 @@ static int qede_set_link_ksettings(struct net_device *dev,
                        }
                        params.adv_speeds = QED_LM_50000baseKR2_Full_BIT;
                        break;
-               case 0xbeef:
+               case SPEED_100000:
                        if (!(current_link.supported_caps &
                              QED_LM_100000baseKR4_Full_BIT)) {
                                DP_INFO(edev, "100G speed not supported\n");